Add a note for image automation to upgrade guide #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
area/docs
|
thanks 👍 |
hiddeco
reviewed
Sep 20, 2023
Comment on lines
46
to
47
| If you've enabled the Flux [image automation feature](/flux/guides/image-update/) at bootstrap, | ||
| make sure to include the image automation controllers when generating the components manifest: |
There was a problem hiding this comment.
Suggested change
| If you've enabled the Flux [image automation feature](/flux/guides/image-update/) at bootstrap, | |
| make sure to include the image automation controllers when generating the components manifest: | |
| If you've enabled extra Flux components at bootstrap, like those required for the [image automation feature](/flux/guides/image-update/). | |
| Ensure to include these components when generating the components manifest: |
Makes it more future safe, in case we ever introduce new components.
In addition, maybe put this in some kind of warning / note / whatever block?
There was a problem hiding this comment.
There is an info box right after this, too many of those I think it just creates noise.
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
upgrade-components-extra
branch
from
fe4e6b2
to
996a12f
Compare
hiddeco
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example on how to upgrade when the Flux image automation feature has been enabled at bootstrap.
Closes: fluxcd/flux2#4259